Join types #1840
Merged
Join types #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pretty simple, just lets you specify a type of join if you want to.
Swahvay
commented
Nov 8, 2024
| import * as clause from "./clause"; | ||
| import { Data, ID, LoadRowsOptions } from "./base"; | ||
| import { v1 } from "uuid"; | ||
| import { MockLogs } from "../testutils/mock_log"; |
There was a problem hiding this comment.
Sorry, I have my editor set up to alphabetize imports.
lolopinto
reviewed
Nov 9, 2024
ts/src/core/query_impl.ts
Outdated
Comment on lines
56
to
64
| join.type === "left" | ||
| ? "LEFT JOIN" | ||
| : join.type === "right" | ||
| ? "RIGHT JOIN" | ||
| : join.type === "outer" | ||
| ? "FULL OUTER JOIN" | ||
| : join.type === "inner" | ||
| ? "INNER JOIN" | ||
| : "JOIN"; |
There was a problem hiding this comment.
this is not readable lol. can you use a switch statement here?
lolopinto
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple, just lets you specify a type of join if you want to. Fixes #1839.