fix(node): the deploy driver failed with linkerd #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantissahz
force-pushed
the
issue3809
branch
from
e97d157
to
a185919
Compare
innobead
requested changes
Dec 20, 2023
mantissahz
force-pushed
the
issue3809
branch
from
a185919
to
575f1c3
Compare
c3y1huang
reviewed
Dec 20, 2023
mantissahz
force-pushed
the
issue3809
branch
from
575f1c3
to
e008360
Compare
mantissahz
force-pushed
the
issue3809
branch
from
e008360
to
0f041f8
Compare
c3y1huang
previously approved these changes
Dec 20, 2023
Linkerd will inject a container `linkerd-proxy` in the longhorn-manger pod by adding the annotaion `linkerd.io/inject: enabled`. It will fail when we check the `MountPropagation` for the first container that is `linkerd-proxy`. What we want to check is the `longhorn-manager` container. Ref: 3809 Signed-off-by: James Lu <[email protected]>
mantissahz
force-pushed
the
issue3809
branch
from
0f041f8
to
be1cf2f
Compare
innobead
approved these changes
Dec 20, 2023
|
@Mergifyio backport v1.5.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkerd will inject a container
linkerd-proxyin the longhorn-manger pod by adding the annotationlinkerd.io/inject: enabled. It will fail when we check theMountPropagationfor the first container that islinkerd-proxy. What we want to check is thelonghorn-managercontainer.Ref: longhorn/longhorn#3809