Skip to content

Commit

Permalink
[S] Properly handle secrets in reusable workflow (#243)
Browse files Browse the repository at this point in the history
Something like actions/runner#1413
  • Loading branch information
maxh authored Nov 25, 2023
1 parent 28359aa commit 71eafe6
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/release-if-new-version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,6 @@ jobs:
needs: 'version-check'
if: needs.version-check.outputs.new-version
uses: ./.github/workflows/release.yml
secrets:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
5 changes: 5 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ name: Release

on:
workflow_call:
secrets:
GITHUB_TOKEN:
required: true
NPM_TOKEN:
required: true
workflow_dispatch:

concurrency:
Expand Down

0 comments on commit 71eafe6

Please sign in to comment.