Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info Table improvements #318

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Info Table improvements #318

merged 7 commits into from
Jul 18, 2024

Conversation

bjorkert
Copy link
Contributor

New Info Table Items:
• Target: Displays the current target. If there is an override or temporary target affecting the target, it will show “profile target -> effective target.”
• ISF (Insulin Sensitivity Factor): Displays the current ISF. If there is an override, temporary target, or autosens affecting the ISF, it will show “profile ISF -> effective ISF.”
• CR (Carb Ratio): Displays the current carb ratio. Shows “profile value -> effective value” if they differ.
• Updated: Indicates when the data was uploaded to Nightscout.
• TDD (Total Daily Dosage): Shows the total daily dosage (currently not uploaded to Trio dev).

Modified Info Table Items:
• Basal: If there is a temporary basal, it will show “profile basal -> current basal.” This applies to both Loop and Trio users.

Behind the Scenes:

This pull request includes significant refactoring:

•	Introduced HKQuantity for blood glucose values, applied to most of the info table code.
•	Replaced magic numbers for updating info table rows with an enum.
•	Centralized the updating of the info table to a manager.
•	Removed unnecessary UserDefaults values.
•	Replaced instances where insulin and carbs was stored as strings with a Metric class.
•	Introduced a ProfileManager to keep track of profile values.

@marionbarker marionbarker merged commit a392f74 into dev Jul 18, 2024
@marionbarker marionbarker deleted the infotable-trio branch July 19, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants