Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove decimal coercion from queries #498

Merged
merged 1 commit into from
Feb 25, 2019

Conversation

b-admike
Copy link
Contributor

Description

Following the fix in loopback-connector to get nested property definitions in loopbackio/loopback-connector#136 and loopbackio/loopback-connector#138, we need to modify tests calling find/delete to not coerce queries into decimal values. Before there was a limitation where we receive undefined for the property definition for nested properties, but now we can call these functions using string values as intended in the docs.

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@b-admike b-admike self-assigned this Feb 25, 2019
@b-admike b-admike requested review from jannyHou and a team February 25, 2019 21:00
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good job to have the nested property support from juggler, LGTM when CI green.

@b-admike
Copy link
Contributor Author

Thanks for letting me know the expected behaviour @jannyHou 😄

@b-admike
Copy link
Contributor Author

@slnode test please

@b-admike
Copy link
Contributor Author

b-admike commented Feb 25, 2019

@jannyHou the tests on windows have not been passing for the past 4.5 months (thanks @rmg for the tip), and the changes are minor, so I'd like to ignore them given all other builds are passing (see #485)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants