feat: add DataSource.deleteAllModels() API #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
dhmlau,
emonddr,
jannyHou and
zbarbuto
as code owners
b-admike
approved these changes
Jul 18, 2019
There was a problem hiding this comment.
LGTM in terms of code and the reasons behind it. I suggest waiting for an approval from @raymondfeng before landing.
emonddr
approved these changes
Jul 18, 2019
b-admike
reviewed
Jul 18, 2019
Good catch! Of course we want to update typings too. |
bajtos
force-pushed
the
feat/reset-datasource
branch
from
fde6d6a
to
1f8f100
Compare
|
Amended the commit to include changes in |
raymondfeng
reviewed
Jul 18, 2019
When writing tests, for performance reasons we often want to reuse the same data-source instance for many tests suites. At the same time, we want to keep such test suites independent and allow them to reuse the same model name for different model classes. Juggler does support redefinition of a model with the same name. This change is adding a new API called that allows tests to remove all old models before creating new ones. This API would be typically called from a `before` hook. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
force-pushed
the
feat/reset-datasource
branch
from
1f8f100
to
78c5b12
Compare
|
@raymondfeng LGTY now? |
raymondfeng
approved these changes
Jul 18, 2019
bajtos
changed the title
4 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing tests, for performance reasons we often want to reuse the same data-source instance for many tests suites. At the same time, we want to keep such test suites independent and allow them to reuse the same model name for different model classes.
Juggler does support redefinition of a model with the same name.
This change is adding a new API called
dataSource.reset()that allows tests to remove all old models before creating new ones (typically from abeforehook).Related issues
This is very loosely related to loopbackio/loopback-next#3387.
Checklist
guide