New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support loging in with username #10559

Open

aaqilniz wants to merge 1 commit into loopbackio:master from aaqilniz:feat/support-username-login

Contributor

aaqilniz commented Jun 7, 2024

This PR enables authentication-jwt to login user with username too.

Checklist

DCO (Developer Certificate of Origin) signed in all commits
npm test passes on your machine
New tests added or existing tests modified to cover all changes
Code conforms with the style guide
API Documentation in code was updated
Documentation in /docs/site was updated
Affected artifact templates in packages/cli were updated
Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

coveralls commented Jun 7, 2024 •

edited

Loading

Pull Request Test Coverage Report for Build 9421149415

Details

6 of 8 (75.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.003%) to 55.29%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
extensions/authentication-jwt/src/services/user.service.ts	6	8	75.0%

Totals
Change from base Build 9419955538:	0.003%
Covered Lines:	9571
Relevant Lines:	12472

💛 - Coveralls


          feat: support loging in with username

536b7ec

Signed-off-by: Muhammad Aaqil <[email protected]>

aaqilniz force-pushed the feat/support-username-login branch from 381295f to 536b7ec Compare

August 24, 2024 14:37

aaqilniz marked this pull request as ready for review

August 24, 2024 15:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet