build: fix tslint issues related to promises #1651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-admike
approved these changes
Aug 28, 2018
raymondfeng
approved these changes
Aug 28, 2018
jannyHou
approved these changes
Aug 28, 2018
hacksparrow
reviewed
Aug 29, 2018
| @@ -45,7 +45,7 @@ describe('RestServer (integration)', () => { | |||
|
|
|||
| it('honors port binding after instantiation', async () => { | |||
| const server = await givenAServer({rest: {port: 80}}); | |||
| await server.bind(RestBindings.PORT).to(0); | |||
There was a problem hiding this comment.
@bajtos why was await removed here and other places as well?
There was a problem hiding this comment.
Because they were used incorrectly ... server.bind doesn't return a promise and as such the await wasn't needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up for #1648.
It makes me wonder why
tslintis not reporting these promise-related problems whenno-unused-variableis enabled, but I can't be bothered to investigate.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated