docs: add specific relation decorators #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabdelgadir
force-pushed
the
relation-decorator-doc
branch
from
8ea1630
to
8ea5b32
Compare
bajtos
previously requested changes
Jan 7, 2019
There was a problem hiding this comment.
Great addition to our docs.
While changing this area, I think we should also modify or remove the following note on lines 122/123 and 133/134. Perhaps explain what has been finished & released for general use, what is not implemented yet, and add links to GitHub issues where readers can find more information about the progress.
_This feature has not yet been released in alpha form. Documentation will be
added here as this feature progresses._
nabdelgadir
force-pushed
the
relation-decorator-doc
branch
2 times, most recently
from
729ef04
to
a9d883f
Compare
b-admike
reviewed
Jan 9, 2019
bajtos
dismissed
their stale review
the original comments have been addressed
nabdelgadir
force-pushed
the
relation-decorator-doc
branch
from
a9d883f
to
8d7bc26
Compare
nabdelgadir
force-pushed
the
relation-decorator-doc
branch
from
8d7bc26
to
43c98e8
Compare
nabdelgadir
force-pushed
the
relation-decorator-doc
branch
from
43c98e8
to
4464c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect to #1910.
Add syntax and examples to
belongsTo,hasOne, andhasManydecorator docs.Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated