Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(docs): has-one-relation typo corrected #2243

Closed
wants to merge 1 commit into from

Conversation

milindsingh
Copy link

@milindsingh milindsingh commented Jan 13, 2019

Doc has a typo in function name createHasOneRepositoryFactoryFor -> _createHasOneRepositoryFactoryFor

Checklist

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@milindsingh milindsingh changed the title Update hasOne-relation.md Typo Fixed in hasOne-relation.md Jan 13, 2019
@milindsingh milindsingh changed the title Typo Fixed in hasOne-relation.md docs(has-one-relation): typo corrected Jan 14, 2019
@milindsingh milindsingh changed the title docs(has-one-relation): typo corrected docs(docs): has-one-relation typo corrected Jan 14, 2019
@bajtos
Copy link
Member

bajtos commented Jan 14, 2019

Hi @milindsingh, thank you for the pull request. The API _createHasOneRepositoryFactoryFor has been deprecated in favor of createHasOneRepositoryFactoryFor, so the documentation is correct. I guess it's examples/todo-list/src/repositories/todo-list.repository.ts that needs to be fixed to use the new API.

@bajtos bajtos closed this Jan 14, 2019
@bajtos
Copy link
Member

bajtos commented Jan 14, 2019

Oh, on the second thought, it looks like createHasOneRepositoryFactoryFor was not created yet. We use this new form for the following methods only: createHasManyRepositoryFactoryFor and createBelongsToAccessorFor.

So the problem should be fixed by modifying DefaultCrudRepository to implement createHasOneRepositoryFactoryFor and deprecate _createHasOneRepositoryFactoryFor.

@milindsingh
Copy link
Author

@bajtos Thanks
Can you update me about the ETA for createHasOneRepositoryFactoryFor to be implemented? as far as I now swagger explorer does not reflect the relation in response. #2209

@milindsingh milindsingh deleted the typo-fix branch January 18, 2019 07:06
@bajtos
Copy link
Member

bajtos commented Jan 18, 2019

Can you update me about the ETA for createHasOneRepositoryFactoryFor to be implemented?

@b-admike you are working on relations, do you happen to know if there is any ETA for full has-one support?

@milindsingh Would you mind contributing the small improvement I described in my comment above?

the problem should be fixed by modifying DefaultCrudRepository to implement createHasOneRepositoryFactoryFor and deprecate _createHasOneRepositoryFactoryFor.

As far as I now swagger explorer does not reflect the relation in response. #2209

Let's keep this discussion inside #2209.

@bajtos bajtos self-assigned this Jan 18, 2019
@bajtos bajtos added the Relations Model relations (has many, etc.) label Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Relations Model relations (has many, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants