Scaffold test files to src/__tests__ + small fixes
#2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework our project templates to place test files to `src/__tests__`.
- Source files are compiled from `src/{foo}` to `dist/{foo}`, the same
pattern is applied to test files too.
- Both TypeScript sources and JavaScript output are stored in the same
path relative to project root. This makes it much easier to refer
to test fixtures.
This is a follow-up for 066d525, 91a37dc and 1a6ac91.
bajtos
force-pushed
the
refactor/templates-test-dir
branch
from
fa6c3d2
to
c268d5a
Compare
b-admike
approved these changes
Feb 5, 2019
raymondfeng
approved these changes
Feb 5, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last pull request in my series of small changes migrating our test files from
testtosrc/__tests__.The first commit reworks our CLI templates to scaffold test files to
src/__tests__.The remaining commits are fixing places that I forgot to update in my previous pull requests #2283, #2316 and #2330.
See also #1636.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated