refactor(rest): rework StaticAssetsRoute into ExternalExpressRoutes #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
added
refactor
REST
bajtos
commented
Mar 4, 2019
| @@ -143,15 +135,14 @@ export class RoutingTable { | |||
| return found; | |||
| } | |||
|
|
|||
| // this._staticAssetsRoute will be set only if app.static() was called | |||
There was a problem hiding this comment.
Please note this comment is no longer true, RestServer is always creating a new instance of StaticAssetsRoute/ExternalRoutes. I am not sure if that's a good thing and an intentional behavior. Either way, fixing it is out of scope of this pull request.
4 tasks
hacksparrow
approved these changes
Mar 4, 2019
bajtos
force-pushed
the
refactor/external-express-routes
branch
from
fabe7b9
to
81be871
Compare
raymondfeng
approved these changes
Mar 4, 2019
Refactor the code handling static assets routes to make it open to extension and allow adding additional types of external routes later in the (near) future. This commit is a pure refactoring. The only visible change is removal of `StaticAssetsRoute` from the public API.
bajtos
force-pushed
the
refactor/external-express-routes
branch
from
81be871
to
e40c1d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the code handling static assets routes to make it open to extension and allow adding additional types of external routes later in the (near) future.
This commit is a pure refactoring. The only visible change is removal of
StaticAssetsRoutefrom the public API.See #2389 and the PoC in #2318.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated