Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] feat(socketio): add support for Socket.IO to expose WebSocket endpoints #2648

Closed
wants to merge 1 commit into from

Conversation

raymondfeng
Copy link
Contributor

@raymondfeng raymondfeng commented Mar 26, 2019

Starting to add SocketIOServer and explore how to decorate a controller to respond to corresponding events for incoming requests.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

@raymondfeng raymondfeng force-pushed the socketio branch 4 times, most recently from 423d70b to e10965b Compare March 28, 2019 22:02
@bajtos
Copy link
Member

bajtos commented Mar 29, 2019

+1 to explore socket.io integration 👍

@raymondfeng to make review easier, can you treat this pull request as a spike please? It would be great to add _SPIKE_.md document to monorepo root and write down a high-level overview of the most important aspects of the implementation you are proposing.

@raymondfeng
Copy link
Contributor Author

@bajtos I started to add more information into the README.

@octisfall
Copy link

@raymondfeng npm install --save @loopback/socketio returns 404

@bajtos
Copy link
Member

bajtos commented Apr 18, 2019

I'd like to put this pull request on hold until we figure out how to approach experimental features - see #2676

@raymondfeng
Copy link
Contributor Author

Move to strongloop/loopback-labs#4

@bajtos bajtos deleted the socketio branch May 14, 2019 14:12
@wiedzmin26
Copy link

@raymondfeng When will it be ready?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants