Rename CrudConnectorFeatures to CrudFeatures

acceptance/repository-mongodb/src/__tests__/mongodb.datasource.ts

@@ -3,10 +3,7 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-import {
-  CrudConnectorFeatures,
-  DataSourceOptions,
-} from '@loopback/repository-tests';
+import {CrudFeatures, DataSourceOptions} from '@loopback/repository-tests';
 
 const connector = require('loopback-connector-mongodb');
 
@@ -17,6 +14,6 @@ export const MONGODB_CONFIG: DataSourceOptions = {
   database: process.env.MONGODB_DATABASE || 'repository-tests',
 };
 
-export const MONGODB_FEATURES: Partial<CrudConnectorFeatures> = {
+export const MONGODB_FEATURES: Partial<CrudFeatures> = {
   idType: 'string',
 };

acceptance/repository-mysql/src/__tests__/mysql.datasource.ts

@@ -3,10 +3,7 @@
 // This file is licensed under the MIT License.
 // License text available at https://opensource.org/licenses/MIT
 
-import {
-  CrudConnectorFeatures,
-  DataSourceOptions,
-} from '@loopback/repository-tests';
+import {CrudFeatures, DataSourceOptions} from '@loopback/repository-tests';
 
 const connector = require('loopback-connector-mysql');
 
@@ -20,7 +17,7 @@ export const MYSQL_CONFIG: DataSourceOptions = {
   createDatabase: true,
 };
 
-export const MYSQL_FEATURES: Partial<CrudConnectorFeatures> = {
+export const MYSQL_FEATURES: Partial<CrudFeatures> = {
   idType: 'number',
   freeFormProperties: false,
 };

packages/repository-tests/src/crud-test-suite.ts

@@ -9,7 +9,7 @@ import * as fs from 'fs';
 import * as path from 'path';
 import {withCrudCtx} from './helpers.repository-tests';
 import {
-  CrudConnectorFeatures,
+  CrudFeatures,
   CrudRepositoryCtor,
   CrudTestContext,
   DataSourceOptions,
@@ -20,15 +20,15 @@ const debug = debugFactory('loopback:repository-tests');
 type SuiteFn = (
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudConnectorFeatures,
+  connectorFeatures: CrudFeatures,
 ) => void;
 
 export function crudRepositoryTestSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: Partial<CrudConnectorFeatures>,
+  connectorFeatures: Partial<CrudFeatures>,
 ) {
-  const features: CrudConnectorFeatures = {
+  const features: CrudFeatures = {
     idType: 'string',
     freeFormProperties: true,
     ...connectorFeatures,

packages/repository-tests/src/crud/create-retrieve.suite.ts

@@ -8,7 +8,7 @@ import {EntityCrudRepository} from '@loopback/repository/src';
 import {expect, toJSON} from '@loopback/testlab';
 import {withCrudCtx} from '../helpers.repository-tests';
 import {
-  CrudConnectorFeatures,
+  CrudFeatures,
   CrudRepositoryCtor,
   CrudTestContext,
   DataSourceOptions,
@@ -19,7 +19,7 @@ import {
 export function createRetrieveSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudConnectorFeatures,
+  connectorFeatures: CrudFeatures,
 ) {
   @model()
   class Product extends Entity {

packages/repository-tests/src/crud/freeform-properties.suite.ts

@@ -9,7 +9,7 @@ import {expect, skipIf, toJSON} from '@loopback/testlab';
 import {Suite} from 'mocha';
 import {withCrudCtx} from '../helpers.repository-tests';
 import {
-  CrudConnectorFeatures,
+  CrudFeatures,
   CrudRepositoryCtor,
   CrudTestContext,
   DataSourceOptions,
@@ -18,7 +18,7 @@ import {
 export function freeformPropertiesSuite(
   dataSourceOptions: DataSourceOptions,
   repositoryClass: CrudRepositoryCtor,
-  connectorFeatures: CrudConnectorFeatures,
+  connectorFeatures: CrudFeatures,
 ) {
   skipIf<[(this: Suite) => void], void>(
     !connectorFeatures.freeFormProperties,

packages/repository-tests/src/types.repository-tests.ts

@@ -16,11 +16,11 @@ import {
 export type DataSourceOptions = Options;
 
 /**
- * List of flags describing connector-specific behavior. These flags
- * are used by the test suite to tweak assertions and skip tests
- * for scenarios not supported by some connectors.
+ * List of flags describing behavior specific to different connectors and
+ * repository implementations. These flags are used by the test suite to tweak
+ * assertions and skip tests for scenarios not supported by some implementations.
  */
-export interface CrudConnectorFeatures {
+export interface CrudFeatures {
   /**
    * What type is used for auto-generated primary keys?
    * - SQL databases typically use auto-incremented numbers,
@@ -60,6 +60,6 @@ export type CrudRepositoryCtor = new <
 export interface CrudTestContext {
   dataSourceOptions: DataSourceOptions;
   repositoryClass: CrudRepositoryCtor;
-  connectorFeatures: CrudConnectorFeatures;
+  connectorFeatures: CrudFeatures;
   dataSource: juggler.DataSource;
 }

tsconfig.json

@@ -1,12 +1,14 @@
 {
   "extends": "./packages/build/config/tsconfig.common.json",
   "include": [
+    "acceptance",
     "benchmark",
     "examples",
     "packages"
   ],
   "exclude": [
     "node_modules/**",
+    "acceptance/node_modules/**",
     "benchmark/node_modules/**",
     "examples/*/node_modules/**",
     "packages/*/node_modules/**",