Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(example-todo-list): use real relation resolvers #3774

Merged
merged 1 commit into from
Sep 25, 2019
Merged

feat(example-todo-list): use real relation resolvers #3774

merged 1 commit into from
Sep 25, 2019

Conversation

nabdelgadir
Copy link
Contributor

@nabdelgadir nabdelgadir commented Sep 20, 2019 •
edited
Loading

hasMany, belongsTo, and hasOne factories have an inclusion resolver property that we can leverage in this example

Resolves #3450

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@nabdelgadir nabdelgadir self-assigned this Sep 20, 2019
agnes512
agnes512 reviewed Sep 20, 2019
View reviewed changes
Copy link
Contributor

@agnes512 agnes512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhmlau dhmlau mentioned this pull request Sep 23, 2019
Closed
2 tasks
@nabdelgadir nabdelgadir marked this pull request as ready for review September 25, 2019 12:43
jannyHou
jannyHou approved these changes Sep 25, 2019
View reviewed changes
Copy link
Contributor

@jannyHou jannyHou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 LGTM

@dhmlau
Copy link
Member

dhmlau commented Sep 25, 2019

Please squash the commits before merging. Thanks.

@nabdelgadir
feat(example-todo-list): use real relation resolvers
61e2ef0 
hasMany, belongsTo, and hasOne factories have an inclusion resolver property that we can leverage in this example
@nabdelgadir nabdelgadir merged commit 39468e0 into master Sep 25, 2019
@nabdelgadir nabdelgadir deleted the update-todo-list branch September 25, 2019 16:47
bajtos
bajtos reviewed Sep 26, 2019
View reviewed changes
Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bajtos bajtos bajtos left review comments

@raymondfeng raymondfeng raymondfeng approved these changes

@jannyHou jannyHou jannyHou approved these changes

@dhmlau dhmlau dhmlau approved these changes

@agnes512 agnes512 agnes512 approved these changes

Assignees

@nabdelgadir nabdelgadir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update todo-list example to use inclusion resolver
6 participants
@nabdelgadir @dhmlau @raymondfeng @bajtos @jannyHou @agnes512