-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(example-coffeeshop): add coffeeshop example #4664
Conversation
@derdeka Do you plan to consolidate with https://github.com/dhmlau/loopback4-coffeeshop/ and port the UI from LB3 as well? |
The initial idea was to build the |
Thank you @derdeka for the pull request. I like the idea of having an example app showing a full stack LoopBack + Angular application ❤️ Ideally, I would like such app show not only how to write the app, but also include proper test suite including end-to-end tests executed in the browser. Now running tests in a browser is a bit involved, I am reluctant to include such tests in loopback-next - I am concerned about extra duration they would add to our already slow test suite. Personally, I would prefer to create a dedicated repository for this example application. Thoughts? |
@dhmlau I have assigned you as the primary reviewer, feel free to bring other core team members to help with the review. (Do we have anybody familiar with Angular on our team?) |
We just switch the contribution method from CLA to DCO, making your contribution easier in the future. Please sign the commits with DCO by amending your commit messages with
Please refer to this docs page for details. Thanks! |
This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the |
Implements coffeeshop as example, migrated from https://github.com/strongloop/loopback-getting-started-intermediate
Fixes #635
Related to #4610
After commiting i discoverd that @dhmlau did already something similar: https://github.com/dhmlau/loopback4-coffeeshop/
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈