Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(example-coffeeshop): add coffeeshop example #4664

Closed
wants to merge 5 commits into from
Closed

Conversation

derdeka
Copy link
Contributor

@derdeka derdeka commented Feb 17, 2020

Implements coffeeshop as example, migrated from https://github.com/strongloop/loopback-getting-started-intermediate

Fixes #635
Related to #4610

After commiting i discoverd that @dhmlau did already something similar: https://github.com/dhmlau/loopback4-coffeeshop/

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@raymondfeng
Copy link
Contributor

@derdeka Do you plan to consolidate with https://github.com/dhmlau/loopback4-coffeeshop/ and port the UI from LB3 as well?

@derdeka
Copy link
Contributor Author

derdeka commented Mar 20, 2020

@derdeka Do you plan to consolidate with https://github.com/dhmlau/loopback4-coffeeshop/ and port the UI from LB3 as well?

The initial idea was to build the angular example on top of this lb4 example.

@dhmlau
Copy link
Member

dhmlau commented Mar 24, 2020

@derdeka, are you looking into this #4849 too? This is to create a tutorial to go from LoopBack to Angular. Thanks.

@bajtos
Copy link
Member

bajtos commented Apr 3, 2020

Thank you @derdeka for the pull request. I like the idea of having an example app showing a full stack LoopBack + Angular application ❤️

Ideally, I would like such app show not only how to write the app, but also include proper test suite including end-to-end tests executed in the browser.

Now running tests in a browser is a bit involved, I am reluctant to include such tests in loopback-next - I am concerned about extra duration they would add to our already slow test suite.

Personally, I would prefer to create a dedicated repository for this example application.

Thoughts?

@bajtos bajtos added the Examples label Apr 3, 2020
@bajtos bajtos requested a review from dhmlau April 3, 2020 14:11
@bajtos
Copy link
Member

bajtos commented Apr 3, 2020

@dhmlau I have assigned you as the primary reviewer, feel free to bring other core team members to help with the review. (Do we have anybody familiar with Angular on our team?)

@dhmlau
Copy link
Member

dhmlau commented Aug 19, 2020

We just switch the contribution method from CLA to DCO, making your contribution easier in the future. Please sign the commits with DCO by amending your commit messages with -s flag and push the changes again. If you're using the command line, you can:

git commit --amend -s
git push --force-with-lease

Please refer to this docs page for details. Thanks!

@bajtos bajtos added the stale label Aug 20, 2020
@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

@stale stale bot closed this Sep 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a LB4 version of CoffeeShop app
4 participants