feat: lb3 migration tests for models customized with db metadata #4710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepakrkris
force-pushed
the
issue3810
branch
from
659f9f7
to
2123ed1
Compare
deepakrkris
requested review from
agnes512,
emonddr and
nabdelgadir
as code owners
deepakrkris
force-pushed
the
issue3810
branch
3 times, most recently
from
4086110
to
16f22f3
Compare
deepakrkris
requested review from
hacksparrow and
raymondfeng
as code owners
|
@deepakrkris, there's error in |
jannyHou
approved these changes
Feb 25, 2020
deepakrkris
force-pushed
the
issue3810
branch
from
16f22f3
to
4d7dee0
Compare
bajtos
approved these changes
Feb 25, 2020
derdeka
reviewed
Feb 25, 2020
| type: `'string'`, | ||
| tsType: 'string', | ||
| length: 25, | ||
| postgresql: `{columnName: 'name', dataType: 'character varying', dataLength: 25, dataPrecision: null, dataScale: null, nullable: 'YES'}`, |
There was a problem hiding this comment.
@deepakrkris I'm just wondering why a string and not an object passed here. Why is this not like this?:
{
type: `'string'`,
tsType: 'string',
length: 25,
postgresql: {
columnName: 'name',
dataType: 'character varying',
dataLength: 25,
dataPrecision: null,
dataScale: null,
nullable: 'YES'
},
},There was a problem hiding this comment.
@derdeka thanks for the review. The unit test is for the function importLb3ModelDefinition it returns json values as strings. But the template generator takes care of converting into json objects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
satisfies: #3810
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈