-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(boot): add more helper methods for model and application booters #5432
Conversation
applicationBooter
method to BootMixin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for converting my suggestions into a pull request!
The changes look mostly good to me, please get the final approval from code owners.
constructor() { | ||
super(); | ||
this.projectRoot = __dirname; | ||
this.applicationBooter(app); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the method name start with a verb, e.g. this.addApplicationBooter
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I choose a noun to be consistent with other methods.
This further simplifies how a main application can boot sub-applications. The idea was from @bajtos in one of the comments (I cannot find it anymore :-).
Add
model()
toRepositoryMixin
and use it for model booter (feat(cli): bind model classes during boot #5378 (comment))Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈