Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable manual TX with the middle GPIO button #42

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

kareiva
Copy link
Contributor

@kareiva kareiva commented Oct 11, 2021

Allow manual TXing using the middle GPIO button on the T-Beam.

By enabling the Config.beacon.button_tx setting, users will be able to manually trigger the beacon, if all the other update conditions are met (GPS location fixed, etc.).

Tested with T-Beam V1 and with a TTGO LoRa32 as the iGate

Used the Arduino OneButton library (found it to be successfully used in other projects on T-Beam):
https://github.com/geeksville/OneButton.git

@kareiva
Copy link
Contributor Author

kareiva commented Oct 11, 2021

Raw packets of the testing station LY2EN-5:
https://www.aprsdirect.com/details/raw/sid/4840660

@peterus
Copy link
Member

peterus commented Oct 11, 2021

@kareiva please fix the two cppcheck issues and add the version-style from OneButton into the platformio.ini file (that it is looking the same as from the other libs).
other than this, i will merge this PR asap 😉

@kareiva
Copy link
Contributor Author

kareiva commented Oct 11, 2021

@kareiva please fix the two cppcheck issues and add the version-style from OneButton into the platformio.ini file (that it is looking the same as from the other libs). other than this, i will merge this PR asap 😉

Hope the cppcheck will go through this time :) Also I think I've found a compatible library straight from platformio (https://platformio.org/lib/show/11802/OneButton) which seems to work just fine and hopefully will serve as foundation for future features, such as handling long clicks, double-clicks, etc.

Thanks for looking at this.

@kareiva
Copy link
Contributor Author

kareiva commented Oct 11, 2021

Also with this, I assume you don't mind me moving the send_update variable to the global scope 😁

@peterus peterus merged commit 7eddb53 into lora-aprs:master Oct 11, 2021
@kareiva kareiva deleted the button_tx branch October 11, 2021 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants