-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Снижение градуса спама в логах #712
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alek13
approved these changes
Aug 22, 2022
ssdaniel24
force-pushed
the
removing-warnings
branch
from
August 22, 2022 20:55
d80ac8b
to
e55d99f
Compare
weqqr
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
"Irrlicht: PNG warning: iCCP: known incorrect sRGB profile" Thanks `pngcrush` for detecting those erroneous files!
"Irrlicht: PNG warning: Interlace handling should be turned on when using png_read_image" There is very old bug of libpng. So, this commit solves foreign bug. Thanks `imagemagick` for finding problem image: `magick some_img.png json: | jq '.[0].image.interlace'`
But, uh, we got another warnings: 2022-08-22 10:02:12: WARNING[Main]: NodeDefManager::deSerialize(): already defined with different ID: stairs:stair_straw 2022-08-22 10:02:12: WARNING[Main]: NodeDefManager::deSerialize(): already defined with different ID: stairs:stair_inner_straw 2022-08-22 10:02:12: WARNING[Main]: NodeDefManager::deSerialize(): already defined with different ID: stairs:stair_outer_straw 2022-08-22 10:02:12: WARNING[Main]: NodeDefManager::deSerialize(): already defined with different ID: stairs:slab_straw
ssdaniel24
force-pushed
the
removing-warnings
branch
from
August 22, 2022 21:05
e55d99f
to
21b28d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Убраны предупреждения о неправильных текстурах, предупреждения о некоторых устаревших функциях. Исправлена ненормальная перезапись льда и сена. Переделаны или перенесены на другой уровень некоторые логи.