Merge pull request #2835 from chakflying/fix/game-list-empty

Fix: getGameList returns nothing on first run
louislam · Feb 24, 2023 · c4a9374 · c4a9374
2 parents cecb0b6 + c65a920
commit c4a9374
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/server/socket-handlers/general-socket-handler.js b/server/socket-handlers/general-socket-handler.js
@@ -9,10 +9,10 @@ let gameList = null;
 
 /**
  * Get a game list via GameDig
- * @returns {any[]}
+ * @returns {Object[]} list of games supported by GameDig
  */
 function getGameList() {
-    if (!gameList) {
+    if (gameList == null) {
         gameList = gameResolver._readGames().games.sort((a, b) => {
             if ( a.pretty < b.pretty ) {
                 return -1;
@@ -22,9 +22,8 @@ function getGameList() {
             }
             return 0;
         });
-    } else {
-        return gameList;
     }
+    return gameList;
 }
 
 module.exports.generalSocketHandler = (socket, server) => {