Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Google Chat Notifications #1045

Merged
merged 6 commits into from
Dec 29, 2021
Merged

Add support for Google Chat Notifications #1045

merged 6 commits into from
Dec 29, 2021

Conversation

bilipp
Copy link
Contributor

@bilipp bilipp commented Dec 11, 2021

Description

This PR adds support for Google Chat notifications.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and test it
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@BufferOverflowed
Copy link

This would be awesome! Is it possible to manually modify/create the files from your PR to add this functionality without waiting for a new release?

@louislam
Copy link
Owner

Notification provider is not only for up/down notification, so it have to be handled general message case.

@louislam louislam added the question Further information is requested label Dec 14, 2021
@bilipp
Copy link
Contributor Author

bilipp commented Dec 15, 2021

Notification provider is not only for up/down notification, so it have to be handled general message case.

Thanks for the hint! Message now only contains the "Application went down" text if the status is DOWN.

@louislam louislam linked an issue Dec 16, 2021 that may be closed by this pull request
1 task
@louislam louislam removed the question Further information is requested label Dec 21, 2021
@louislam louislam merged commit e18d4b6 into louislam:master Dec 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification Webhook: Google Chat
3 participants