Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Badges generator #1712

Closed
wants to merge 6 commits into from
Closed

Conversation

jensneuber
Copy link
Contributor

@jensneuber jensneuber commented Jun 1, 2022

Description

As mentioned in #1119 a generator for monitor badges would be nice to have.

A first draft of what this might look like ( with a little inspiration from my side, see screenshot) should be open for discussion in this PR.

Open questions:

  • Where should the generator be located?
    Initial idea was the edit panel.
    Feat: Badges generator #1712 (comment)
  • Should (parts of) it be collapsible?
    When all form fields are visible the generator takes up a lot of space.
  • Should selected values be saved?
    Right now all changes are lost on reload. This might be on purpose

Type of change

  • User interface (UI)
  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

image

@jensneuber jensneuber changed the title Badges generator Feat: Badges generator Jun 1, 2022
@chakflying
Copy link
Collaborator

Where should the generator be located?

I'd prefer adding a button in Details.vue to a separate page to not complicate the EditMonitor page any further than necessary.

@github-actions
Copy link

github-actions bot commented Dec 5, 2022

We are clearing up our old Pull Requests and yours has been open for 3 months with no activity. Remove stale label or comment or this will be closed in 2 days.

@github-actions github-actions bot added the Stale label Dec 5, 2022
@louislam louislam removed the Stale label Dec 5, 2022
@CommanderStorm
Copy link
Collaborator

@jensneuber Just checking in:

What is needed to get this PR ready for review? (apart from a pretty brutal rebase)
Is there something I can help with?

Asking the hard questions:
Given the huge number of changes to this repository: Is this PR still salvageable?

@jensneuber
Copy link
Contributor Author

jensneuber commented Jan 16, 2023

I am still willing to finish this ( thanks @louislam for un-staling it ), but my current situation leaves little room for side tasks.
This will change and i will continue on this.

Edit: typos

@CommanderStorm
Copy link
Collaborator

CommanderStorm commented May 20, 2023

@jensneuber given that #2915 is nearing the merge, would you consider closing this PR?
Is there something from this PR that should be included in #2915?

@jensneuber
Copy link
Contributor Author

#2915 Looks fantastic!
No need to add sth from this ancient PR.

@jensneuber jensneuber closed this May 22, 2023
@kiznick
Copy link
Contributor

kiznick commented May 23, 2023

@jensneuber I'm sorry for duplicate PR. I don't know that you have already done it.

@jensneuber
Copy link
Contributor Author

@jensneuber I'm sorry for duplicate PR. I don't know that you have already done it.

No hard feelings on my side! I am sorry to not have finished up on what I started and feel glad that someone else was willing to do it.

So thanks @kiznick ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants