-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Badges generator #1712
Feat: Badges generator #1712
Conversation
I'd prefer adding a button in |
We are clearing up our old Pull Requests and yours has been open for 3 months with no activity. Remove stale label or comment or this will be closed in 2 days. |
@jensneuber Just checking in: What is needed to get this PR ready for review? (apart from a pretty brutal rebase) Asking the hard questions: |
a8da3e4
to
7f97d8a
Compare
I am still willing to finish this ( thanks @louislam for un-staling it ), but my current situation leaves little room for side tasks. Edit: typos |
@jensneuber given that #2915 is nearing the merge, would you consider closing this PR? |
#2915 Looks fantastic! |
@jensneuber I'm sorry for duplicate PR. I don't know that you have already done it. |
No hard feelings on my side! I am sorry to not have finished up on what I started and feel glad that someone else was willing to do it. So thanks @kiznick ❤️ |
Description
As mentioned in #1119 a generator for monitor badges would be nice to have.
A first draft of what this might look like ( with a little inspiration from my side, see screenshot) should be open for discussion in this PR.
Open questions:
Initial idea was the edit panel.
Feat: Badges generator #1712 (comment)
When all form fields are visible the generator takes up a lot of space.
Right now all changes are lost on reload. This might be on purpose
Type of change
Checklist
(including JSDoc for methods)
Screenshots (if any)