Fix: Add support for pending & maintenance in badges #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathiash98
reviewed
Jan 5, 2023
Co-authored-by: Frank Elsinga <[email protected]>
chakflying
changed the title
2 tasks
2 tasks
Saibamen
reviewed
Jan 30, 2023
Comment on lines
+150
to
+162
| case 0: | ||
| badgeValues.color = downColor; | ||
| badgeValues.message = downLabel; | ||
| break; | ||
| case 1: | ||
| badgeValues.color = upColor; | ||
| badgeValues.message = upLabel; | ||
| break; | ||
| case 2: | ||
| badgeValues.color = pendingColor; | ||
| badgeValues.message = pendingLabel; | ||
| break; | ||
| case 3: |
There was a problem hiding this comment.
Can you use our key names? (PENDING, UP etc)
There was a problem hiding this comment.
Good point, but this is merged already I'm not sure how should I handle this.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #2456
Type of change
Please delete any options that are not relevant.
Checklist
(including JSDoc for methods)
Screenshots (if any)