Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PagerTree Notification Provider #2728

Merged
merged 3 commits into from
Mar 1, 2023

Conversation

armiiller
Copy link
Contributor

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds PagerTree Notification Provider

Type of change

Please delete any options that are not relevant.

  • User interface (UI) => Adds PagerTree Notification Provider Component (Vue)
  • New feature (non-breaking change which adds functionality) => Adds PagerTree Notification Provider (Server)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas
    (including JSDoc for methods)
  • My changes generate no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

None

@louislam louislam added this to the 1.21.0 milestone Feb 7, 2023
@louislam louislam added the question Further information is requested label Feb 18, 2023
@louislam louislam added question Further information is requested and removed question Further information is requested labels Feb 25, 2023
@louislam
Copy link
Owner

Can you show screesshots of UP/DOWN/TEST notifications? As PagerTree is not available in my country I cannot test it.

image

@armiiller
Copy link
Contributor Author

Hi @louislam - Yes, not a problem. Please see below. Please let me know what else I can provide.

image
image
image

@louislam louislam removed the question Further information is requested label Mar 1, 2023
@louislam louislam merged commit 71c800b into louislam:master Mar 1, 2023
@pavanreddymaley
Copy link

Thanks @armiiller @louislam for adding the pagertree notification provider.

I have update my uptime-kuma instance from 1.19 -> 1.21.3 but I still don't see pagerTree in the notifications provider list. Is there something which I have to explicitly enable to get this working.

Thanks in advance

Screenshot 2023-05-11 at 1 25 13 AM
Screenshot 2023-05-11 at 1 25 29 AM

@louislam
Copy link
Owner

@pavanreddymaley Thanks for the report. I think it was dropped incidentally. I just added it back: a1adc30

@pavanreddymaley
Copy link

Thanks @louislam for the quick response.
will you be releasing a new hot-fix version with the fix ??

@jacoatvatfree
Copy link

jacoatvatfree commented Jun 22, 2023

Same question from me, is there a docker image released that has the Pagertree notification option?

@pavanreddymaley
Copy link

@jacoatvatfree I have updated the container image to 1.22.1 and it is showing pagertree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants