Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore:unified our logging infrastructure to only use log.XYZ #4392

Closed
wants to merge 3 commits into from
Closed

chore:unified our logging infrastructure to only use log.XYZ #4392

wants to merge 3 commits into from

Conversation

CommanderStorm
Copy link
Collaborator

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Our logging infrastructure is split between console.XYZ and log.XYZ.
This PR migrates the usages of console.XYZ to log.XYZ.

Type of change

Please delete any options that are not relevant.

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@louislam
Copy link
Owner

Thanks! But I want to finish the 2.0.0 milestone first. Maybe I put #4391 #4392 #4393 in the 2.1.0 milestone.

@CommanderStorm
Copy link
Collaborator Author

But I want to finish the 2.0.0 milestone first

Sorry if the timing of these PRs made the impression that I wanted them incuded in 2.0 ^^
It was mostly because I noticed that otherwise we won't have any extraction of monitor types (#4393, #4395) in 2.1

@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 20, 2024
@CommanderStorm CommanderStorm changed the title unified our logging infrastructure chore:unified our logging infrastructure to only use log.XYZ Jan 20, 2024
@CommanderStorm CommanderStorm added the pr:needs review this PR needs a review by maintainers or other community members label May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot added pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 23, 2024
@github-actions github-actions bot removed the pr:please resolve merge conflict A merge-conflict needs to be addressed before reviewing makes sense again label Jun 3, 2024
@CommanderStorm CommanderStorm mentioned this pull request Sep 14, 2024
Closed
1 task
fsteinke added a commit to fsteinke/uptime-kuma that referenced this pull request Sep 18, 2024
@fsteinke
feat(logging): integrate prs for louislam#4392 and louislam#4391
11f4fb0
SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Sep 19, 2024
@SapphicCode
chore: unified our logging infrastructure to only use log.XYZ
448c8ac 
Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4392

Squashed commit of the following:

commit 75c4c35
Merge: 14e3c3c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:46:21 2024 +0800

    Merge branch 'master' into unified-logging-infrastructure

commit 14e3c3c
Merge: d622dfb c919d2c
Author: Frank Elsinga <[email protected]>
Date:   Mon Jun 3 16:00:56 2024 +0200

    Merge branch 'master' into unified-logging-infrastructure

commit d622dfb
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:31:10 2024 +0100

    unified our logging infrastructure
SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Sep 19, 2024
@SapphicCode
fix(utils): convert unknown from louislam#4392 to string
4eaf9c7
@SapphicCode SapphicCode mentioned this pull request Sep 19, 2024
Merged
7 tasks
@CommanderStorm
Copy link
Collaborator Author

Closing in favor of #5118

SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Oct 9, 2024
@SapphicCode
chore: unified our logging infrastructure to only use log.XYZ
f2ad128 
Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4392

Squashed commit of the following:

commit 75c4c35
Merge: 14e3c3c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:46:21 2024 +0800

    Merge branch 'master' into unified-logging-infrastructure

commit 14e3c3c
Merge: d622dfb c919d2c
Author: Frank Elsinga <[email protected]>
Date:   Mon Jun 3 16:00:56 2024 +0200

    Merge branch 'master' into unified-logging-infrastructure

commit d622dfb
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:31:10 2024 +0100

    unified our logging infrastructure
@SapphicCode SapphicCode mentioned this pull request Oct 9, 2024
Open
7 tasks
SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Oct 10, 2024
@SapphicCode
chore: unified our logging infrastructure to only use log.XYZ
4ce166c 
Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4392

Squashed commit of the following:

commit 75c4c35
Merge: 14e3c3c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:46:21 2024 +0800

    Merge branch 'master' into unified-logging-infrastructure

commit 14e3c3c
Merge: d622dfb c919d2c
Author: Frank Elsinga <[email protected]>
Date:   Mon Jun 3 16:00:56 2024 +0200

    Merge branch 'master' into unified-logging-infrastructure

commit d622dfb
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:31:10 2024 +0100

    unified our logging infrastructure

(and)

fix(apicache): log line object serialization

Resolves the following trace:

Trace: TypeError: Cannot convert object to primitive value
    at res.end (<snip>/uptime-kuma/server/modules/apicache/apicache.js:308:64)
    at ServerResponse.send (<snip>/uptime-kuma/node_modules/express/lib/response.js:233:10)
    at ServerResponse.json (<snip>/uptime-kuma/node_modules/express/lib/response.js:279:15)
    at module.exports.sendHttpError (<snip>/uptime-kuma/server/util-server.js:806:25)
    at <snip>/uptime-kuma/server/routers/status-page-router.js:58:9
    at process.unexpectedErrorHandler (<snip>/uptime-kuma/server/server.js:1858:13)
    at process.emit (node:events:519:28)
    at emitUnhandledRejection (node:internal/process/promises:250:13)
    at throwUnhandledRejectionsMode (node:internal/process/promises:385:19)
    at processPromiseRejections (node:internal/process/promises:470:17)
    at process.processTicksAndRejections (node:internal/process/task_queues:96:32)

(and)

build: recompile `utils.js`
SapphicCode added a commit to SapphicCode/fork-uptime-kuma that referenced this pull request Oct 10, 2024
@SapphicCode
chore: unified our logging infrastructure to only use log.XYZ
800d868 
Co-authored-by: Frank Elsinga <[email protected]>
Closes: louislam#4392

Squashed commit of the following:

commit 75c4c35
Merge: 14e3c3c dd75890
Author: Frank Elsinga <[email protected]>
Date:   Fri Sep 13 22:46:21 2024 +0800

    Merge branch 'master' into unified-logging-infrastructure

commit 14e3c3c
Merge: d622dfb c919d2c
Author: Frank Elsinga <[email protected]>
Date:   Mon Jun 3 16:00:56 2024 +0200

    Merge branch 'master' into unified-logging-infrastructure

commit d622dfb
Author: Frank Elsinga <[email protected]>
Date:   Thu Jan 18 22:31:10 2024 +0100

    unified our logging infrastructure

(and)

build: recompile `utils.js`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
house keeping pr:needs review this PR needs a review by maintainers or other community members
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@CommanderStorm @louislam @chakflying