Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed a typo for internal, unused part of the file upload icon for status page #4757

Conversation

jmolnar-comparative
Copy link
Contributor

@jmolnar-comparative jmolnar-comparative commented May 13, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Backport of #4750
Fixes #4749

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

@CommanderStorm
Copy link
Collaborator

Thanks for the PR 🎉

@CommanderStorm CommanderStorm merged commit a81f949 into louislam:1.23.X May 13, 2024
14 checks passed
@jmolnar-comparative jmolnar-comparative deleted the jm/v1.23.X-fix-saveStatusPage-icon-nonBase64 branch May 13, 2024 17:30
@CommanderStorm CommanderStorm added the area:status-page Everything related to the status page label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:status-page Everything related to the status page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants