Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: grammatical improvements in contribution guide #5183

Conversation

jasonmic2000
Copy link
Contributor

@jasonmic2000 jasonmic2000 commented Oct 10, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Some grammatical improvements in the CONTRIBUTING.md file that I noticed while reading through to set up my local development environment to check another issue.

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.

@jasonmic2000 jasonmic2000 marked this pull request as ready for review October 10, 2024 04:23
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly really good suggestions 👍
I have noted one comment about one of the grammar fixes below

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the grammar improvements ♥️

@CommanderStorm CommanderStorm merged commit bbc75b8 into louislam:master Oct 10, 2024
5 checks passed
@jasonmic2000 jasonmic2000 deleted the docs-grammatical-improvements-in-contribution-guide branch October 10, 2024 10:51
@jasonmic2000 jasonmic2000 restored the docs-grammatical-improvements-in-contribution-guide branch October 10, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants