-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new notification provider 46elks
#5184
Conversation
…ng spaces and curly braces on right line.
…me line i am on fixing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR
I have left a few suggestions below how this PR can be improved in terms of the UI and code quality.
46elks
Thx for the input I think i have fixed all the suggestion now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new notification provider! 🎉
Note
This PR is part of the v2.0
merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^
All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
This PR adds 46elks as a notification channel for Uptime Kuma
Type of change
Checklist
Screenshots (if any)
UP
DOWN
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.