Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Add custom_http_headers feature #20

Merged
merged 2 commits into from
Apr 15, 2019
Merged

Conversation

leeif
Copy link
Contributor

@leeif leeif commented Mar 30, 2019

No description provided.

@louy
Copy link
Owner

louy commented Apr 11, 2019

Thanks for contributing! Would you mind adding a test to show how this option would work?

@louy louy added the enhancement New feature or request label Apr 11, 2019
@leeif
Copy link
Contributor Author

leeif commented Apr 15, 2019

@louy
I have added a test of this.
Since custom_http_headers works only in a pro plan so I just put it into a comment here.
https://github.com/louy/terraform-provider-uptimerobot/pull/20/files#diff-1496caa481c76670a9af6b48cf8ec22fR182

@louy
Copy link
Owner

louy commented Apr 15, 2019

Shame that I can't run pro tests since I'm not really using UR that much

Hopefully that'll change at some point in the future

Thanks for contributing :)

@louy louy merged commit f375e3f into louy:master Apr 15, 2019
@louy
Copy link
Owner

louy commented Aug 20, 2019

@all-contributors please add leeif for code, test

@allcontributors
Copy link
Contributor

@louy

I've put up a pull request to add @leeif! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants