This repository has been archived by the owner on Jun 11, 2024. It is now read-only.
[WIP] Adds http_auth_type to Monitor Resource #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for specifying the http_auth_type parameter to the monitor resource. Fixes louy#71 Signed-off-by: Jason Rogena <[email protected]>
|
@louy seems the Code Climate checks failed because of duplicate code blocks:
What do you suggest I do? |
|
No worries about the code climate issues i'll disable them. There seems to be an API issue with UR however, where it doesn't return I'm working on fixing the broken tests and will then get this merged |
|
Oh, sorry for that @louy . Thanks for fixing the issue! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for specifying the http_auth_type parameter to the monitor
resource.
Fixes #71
Signed-off-by: Jason Rogena [email protected]