A couple of fixes to make CI tests more resilient #211
Conversation
|
Wow, great ! But it looks like the tests still fail in the ci |
This prevents issues when marshmallow_dataclass is installed in editable mode. (See lovasoa#209, lovasoa#207.)
E.g. marshmallow<3.15 generates a deprecation warning from distutils. There's no reason that should cause a test failure for us.
I have no idea whether this actually affects anything, but might as well keep it up-to-date.
This tracks a change in type of the `attr` parameter to `Field._serialize` made in marshmallow 3.18.0. Here we also switch to using keyword args to typeguard.check_type in an attempt to protect against upcoming [changes in its signature](https://typeguard.readthedocs.io/en/latest/api.html#typeguard.check_type).
…t 0.8.0 This is cherry-picks PR#207 by @vit-zikmund
dairiki
force-pushed
the
bug.test-resilience
branch
from
422759b
to
a0dacc8
Compare
Of course they do! LOL I've fixed things again so that they now pass. I had to include the changes from #207 to get that to happen. I've updated my original description of this PR to match what's currently in it. @lovasoa: Do you want to continue support for python 3.6 (EOL 2021-12), or can that be cleaned out? |
|
Thank you very much @dairiki and @vit-zikmund :) |
|
For python 3.6, it looks like there still are hundreds of daily downloads of marshmallow-dataclass with this python version: https://pypistats.org/packages/marshmallow-dataclass But eventually, when python 3.6 becomes too much of a burden to support, and there are fewer daily downloads, we'll drop support, yes :) |
(This PR in an alternative to #209 and also includes #207.)
Main Changes
Explicitly add pytest’s rootdir to
MYPYPYTHONPATH in our mypy tests.This helps mypy find marshmallow_dataclass when it is installed in editable mode. (Ref #209, #207.)
Do not fail tests upon warnings from external dependencies
We were configuring pytest with
-W error. This means tests failed if any warning was emitted by any dependency.(E.g.
marshmallow<3.15elicits a warning from its use ofdistutils.)Here we update the warning filter so that we only fail on warnings from
marshmallow_dataclassor our tests.Other warnings will still be reported by
pytestbut will not cause our tests to fail.Other Changes
In order to get the CI tests to pass, we also cherry-pick PR #207 from @vit-zikmund
To get pre-commit checks to pass, we update the type of the second parameter to
Union._serializeto match changes made to
Field._serializetyping in marshmallow 3.18.0.(This keeps the pre-commit mypy check from failing due to "Liskov substitution principle" violation.)
Finally, we update the --target-version config for black (though I'm not sure that this makes any practical difference.)