Add support for Dict, List, set, frozenset, Tuple[T, ...], tuple[T, ...] #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already supported `dict` (without explicit generic type parameters), but did not support `Dict`. (Similarly for `list` and `List`.) We supported `typing.Set`, but not the builtin `set`. (Similarly for `typing.FrozenSet` and `frozenset`.) We now support all of the above. Fixes lovasoa#181.
We currently recognize `typing.Sequence[int]` as a homogeneous tuple of ints. This adds support for the (probably more correct) concrete type `tuple[int, ...]` (or `typing.Tuple[int, ...]`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already support a parameterless
dict(which we treat equivalently toDict[Any, Any]). This PR adds support for a parameterlessDictas well. (See #181).Similarly, this adds support for
List.We also add support for the builtin
setandfrozenset. (We already supportedSetandFrozenSet.)In addition, this PR adds support for homogeneous tuples notated as
Tuple[T, ...](ortuple[T, ...]for python 3.9 and above.)We currently support homogeneous tuples only through the notation
Sequence[T]. (It seems generally more correct to me to use concrete rather than abstract types in dataclass declarations — though perhaps arguments could be made either way.)