Skip to content

Commit

Permalink
Remove NaN-check C assert calls in line drawing code.
Browse files Browse the repository at this point in the history
Users can pass NaN point values into line drawing code. love shouldn't abort the entire program if that happens.
  • Loading branch information
slime73 committed Oct 30, 2022
1 parent 6c47966 commit 8cda22e
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/modules/graphics/Polyline.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@

// C++
#include <algorithm>
#include <assert.h>

// treat adjacent segments with angles between their directions <5 degree as straight
static const float LINES_PARALLEL_EPS = 0.05f;
Expand Down Expand Up @@ -192,7 +191,6 @@ void MiterJoinPolyline::renderEdge(std::vector<Vector2> &anchors, std::vector<Ve
if (fabs(det) / (len_s * len_t) < LINES_PARALLEL_EPS && Vector2::dot(s, t) > 0)
{
// lines parallel, compute as u1 = q + ns * w/2, u2 = q - ns * w/2
assert(ns == ns); //NaN check
normals.push_back(ns);
normals.push_back(-ns);
}
Expand All @@ -201,7 +199,6 @@ void MiterJoinPolyline::renderEdge(std::vector<Vector2> &anchors, std::vector<Ve
// cramers rule
float lambda = Vector2::cross((nt - ns), t) / det;
Vector2 d = ns + s * lambda;
assert(d == d); //NaN check
normals.push_back(d);
normals.push_back(-d);
}
Expand Down

0 comments on commit 8cda22e

Please sign in to comment.