Remove deprecated method love.graphics.isCreated from love.errhand

[Sheepolution]

love.graphics.isCreated was removed in 0.9.0 according to the wiki.

[MikuAuahDark]

I'm not quite sure about this.

love/src/modules/graphics/wrap_Graphics.cpp

Line 2991 in 1e69a8c

{ "isCreated", w_isCreated },

love/src/modules/graphics/wrap_Graphics.cpp

Lines 187 to 191 in 1e69a8c

	int w_isCreated(lua_State *L)
	{
	luax_pushboolean(L, instance()->isCreated());
	return 1;
	}

Slime probably can explain?

[slime73]

I did a bit of investigating - love.window.isOpen was added in version 0.9 when window-related functions were moved to their own module. I think love.graphics.isCreated stuck around because it says whether a graphics context is created rather than just whether a window is open - but I think love's internal code makes sure a graphics context is always created if a window is open, when the graphics module is active.

So if that's true, the correct thing might be to mark isCreated as deprecated (and remove the call from the error handler code as well). In any case the wiki isn't accurate right now.

[slime73]

the error handler code moved since this PR was made too, so it will need to be redone (along with marking the function as deprecated), if that's the route people want to take.

That being said, I'm not entirely positive the function has no use in future love versions when other graphics backends are used. I'd have to think more about it (and closely look at my metal code).