Replace autotools with cmake #2001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Probably best illustrated by the fact it's still called OSX, rather than macOS.
Previously there was an early return, trying to match the same thing. Making this explicit allows me to more easily add a linux version.
Used for the ppa builds, so it's nice if they still work.
Since I cannot easily change the variable used there, update the autotools codepath to insert the CMake variable.
Not libliblove.so, but liblove-12.0.so, like with autotools. Note that no liblove.so symlink is created.
bartbes
commented
Dec 31, 2023
bartbes
commented
Dec 31, 2023
|
|
||
| configure_file(platform/unix/love.desktop.in love.desktop @ONLY) | ||
|
|
||
| install(TARGETS ${LOVE_EXE_NAME} ${LOVE_LIB_NAME}) |
There was a problem hiding this comment.
Autotools also installs a liblove.so symlink. As nothing explicitly links against it (except user code?) I'm don't mind skipping that.
There was a problem hiding this comment.
Would that be for allowing require("love") to work from a standalone Lua executable?
There was a problem hiding this comment.
Sort of, it's still not in the normal lua search paths.
There was a problem hiding this comment.
They'll have to do package.preload.love = package.loadlib("path/to/liblove-12.0.so", "luaopen_love") before doing require("love") from my understanding, at least.
bartbes
commented
Dec 31, 2023
And automatically get the timestamp for the changelog too. That does require an update to cmake 3.7, but as far as I can tell we never use a cmake version older than 3.16 (ubuntu 20.04).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1991