Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARM64: build librsvg without the -Zbuild-std feature flag #123

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

kleisauke
Copy link
Collaborator

This feature flag is no longer necessary after PR rust-lang/compiler-builtins#444.

The only downside I can think of is that the standard library is now built without panic_immediate_abort.

@lovell
Copy link
Owner

lovell commented Dec 21, 2021

Thanks Kleis, this definitely simplifies things and speeds up the ARM64 builds by about 10%.

The final binary size is a little bigger, as expected, perhaps ~4%. There's a big difference in the size of the intermediate librsvg static library, which highlights how much extra code the #[derive(Debug)] trait can result in.

Before:

-rw-r--r--    1 root     root       8942772 Dec 20 21:53 librsvg-2.a
-rwxr-xr-x    1 root     root      17326880 Dec 20 21:56 libvips-cpp.so.42.14.1

After:

-rw-r--r--    1 root     root      12015254 Dec 21 10:21 librsvg-2.a
-rwxr-xr-x    1 root     root      17953656 Dec 21 10:24 libvips-cpp.so.42.14.1

@lovell lovell merged commit 0a17d43 into lovell:main Dec 21, 2021
@kleisauke kleisauke deleted the without-build-std branch December 21, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants