Merge pull request #351 from joelmukuthu/master

Fix: default crop gravity to sharp.gravity.center
lovell · Feb 4, 2016 · 320a746 · 320a746
2 parents 322aa60 + da74cd0
commit 320a746
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -231,7 +231,9 @@ module.exports.gravity = {
 
 Sharp.prototype.crop = function(gravity) {
   this.options.canvas = 'crop';
-  if (typeof gravity === 'number' && !Number.isNaN(gravity) && gravity >= 0 && gravity <= 8) {
+  if (typeof gravity === 'undefined') {
+    this.options.gravity = module.exports.gravity.center;
+  } else if (typeof gravity === 'number' && !Number.isNaN(gravity) && gravity >= 0 && gravity <= 8) {
     this.options.gravity = gravity;
   } else if (typeof gravity === 'string' && typeof module.exports.gravity[gravity] === 'number') {
     this.options.gravity = module.exports.gravity[gravity];

diff --git a/test/unit/crop.js b/test/unit/crop.js
@@ -145,4 +145,25 @@ describe('Crop gravities', function() {
       sharp(fixtures.inputJpg).crop('yadda');
     });
   });
+
+  it('does not throw if crop gravity is undefined', function() {
+    assert.doesNotThrow(function() {
+      sharp(fixtures.inputJpg).crop();
+    });
+  });
+
+  it('defaults crop gravity to sharp.gravity.center', function(done) {
+    var centerGravitySettings = testSettings.filter(function (settings) {
+      return settings.name === 'Center';
+    })[0];
+    sharp(fixtures.inputJpg)
+      .resize(centerGravitySettings.width, centerGravitySettings.height)
+      .crop()
+      .toBuffer(function(err, data, info) {
+        if (err) throw err;
+        assert.strictEqual(centerGravitySettings.width, info.width);
+        assert.strictEqual(centerGravitySettings.height, info.height);
+        fixtures.assertSimilar(fixtures.expected(centerGravitySettings.fixture), data, done);
+      });
+  });
 });