Properly emit close event on pipeline stream

lovell · Nov 17, 2021 · 5a460aa · 5a460aa
1 parent 1ff84b2
commit 5a460aa
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/output.js b/lib/output.js
@@ -1078,6 +1078,7 @@ function _pipeline (callback) {
             this.push(data);
           }
           this.push(null);
+          this.emit('close');
         });
       });
       if (this.streamInFinished) {
@@ -1093,6 +1094,7 @@ function _pipeline (callback) {
           this.push(data);
         }
         this.push(null);
+        this.emit('close');
       });
     }
     return this;

diff --git a/test/unit/io.js b/test/unit/io.js
@@ -201,6 +201,21 @@ describe('Input/output', function () {
     readable.pipe(pipeline).pipe(writable);
   });
 
+  it('Stream should emit close event', function (done) {
+    const readable = fs.createReadStream(fixtures.inputJpg);
+    const writable = fs.createWriteStream(outputJpg);
+    const pipeline = sharp().resize(320, 240);
+    let closeEventEmitted = false;
+    pipeline.on('close', function () {
+      closeEventEmitted = pipeline._readableState.closeEmitted;
+    });
+    writable.on('close', function () {
+      assert.strictEqual(true, closeEventEmitted);
+      rimraf(outputJpg, done);
+    });
+    readable.pipe(pipeline).pipe(writable);
+  });
+
   it('Handle Stream to Stream error ', function (done) {
     const pipeline = sharp().resize(320, 240);
     let anErrorWasEmitted = false;