Prevent aliasing by using dynamic values for shrink(-on-load)

lovell · May 13, 2017 · e398b47 · e398b47
1 parent 48f69f3
commit e398b47
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 1 deletion.
diff --git a/docs/changelog.md b/docs/changelog.md
@@ -41,6 +41,10 @@ Requires libvips v8.5.2.
   [#772](https://github.com/lovell/sharp/issues/772)
   [@ajiratech2](https://github.com/ajiratech2)
 
+* Prevent aliasing by using dynamic values for shrink(-on-load).
+  [#781](https://github.com/lovell/sharp/issues/781)
+  [@kleisauke](https://github.com/kleisauke)
+
 * Expose libvips' "squash" parameter to enable 1-bit TIFF output.
   [#783](https://github.com/lovell/sharp/pull/783)
   [@YvesBos](https://github.com/YvesBos)

diff --git a/src/pipeline.cc b/src/pipeline.cc
@@ -242,6 +242,12 @@ class PipelineWorker : public Nan::AsyncWorker {
           shrink_on_load = 2;
         }
       }
+      // Help ensure a final kernel-based reduction to prevent shrink aliasing
+      if (shrink_on_load > 1 && (xresidual == 1.0 || yresidual == 1.0)) {
+        shrink_on_load = shrink_on_load / 2;
+        xfactor = xfactor * 2;
+        yfactor = yfactor * 2;
+      }
       if (shrink_on_load > 1) {
         // Reload input using shrink-on-load
         vips::VOption *option = VImage::option()->set("shrink", shrink_on_load);
@@ -285,6 +291,13 @@ class PipelineWorker : public Nan::AsyncWorker {
           std::swap(xresidual, yresidual);
         }
       }
+      // Help ensure a final kernel-based reduction to prevent shrink aliasing
+      if ((xshrink > 1 || yshrink > 1) && (xresidual == 1.0 || yresidual == 1.0)) {
+        xshrink = xshrink / 2;
+        yshrink = yshrink / 2;
+        xresidual = xresidual / 2.0;
+        yresidual = yresidual / 2.0;
+      }
 
       // Ensure we're using a device-independent colour space
       if (sharp::HasProfile(image)) {

diff --git a/test/fixtures/expected/embed-16bit-rgba.png b/test/fixtures/expected/embed-16bit-rgba.png
diff --git a/test/fixtures/expected/extend-2channel.png b/test/fixtures/expected/extend-2channel.png
diff --git a/test/fixtures/expected/gamma-0.0.jpg b/test/fixtures/expected/gamma-0.0.jpg
diff --git a/test/unit/io.js b/test/unit/io.js
@@ -1335,7 +1335,7 @@ describe('Input/output', function () {
               assert.strictEqual(256, info.width);
               assert.strictEqual(192, info.height);
               assert.strictEqual(4, info.channels);
-              fixtures.assertSimilar(fixtures.inputPngOverlayLayer1, data, done);
+              fixtures.assertSimilar(fixtures.inputPngOverlayLayer1, data, { threshold: 7 }, done);
             });
         });
     });