-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.31.2: macOS x64 prebuilt binaries fail on macOS < 11 with "Symbol not found: _pthread_jit_write_protect_supported_np" #3438
Comments
Also happend on MacOS 10.15.7
|
This looks like something to do with the macOS Hardened Runtime introduced in 10.14 (Mojave). The symbol requirement has been introduced via a commit to the upstream liborc (used by libvips for SIMD) - see commit https://cgit.freedesktop.org/gstreamer/orc/commit/?id=b732715f737595884dd54d1f7860982652b2482f The CI environment used by sharp is running macOS 11 as that's the oldest version available to us (GitHub Actions was supposed to remove 10.15 support entirely a couple of months ago, but it's still flagged as "deprecated" in the docs), so perhaps it's time to upgrade the minimum required version as that's all we can test against? I guess this will affect only x64 hardware. Do all versions of Node.js exhibit this behaviour? Does the Node.js executable itself on these machines support the Hardened Runtime (e.g. via the |
I wonder why Meson returns @eli-schwartz Can I ping you on this? Perhaps we need to explicty pass |
Ah, looking at the GitHub Actions log, it looks like it already warned about this. Details
Perhaps adding Would cause |
This problem appears to affect glib too. The following error occurs when attempting to compile glib with
|
PR to upgrade the minimum macOS to 10.13 as documented, introduce a build-time check for misuse of newer API, plus a temporary workaround for orc at lovell/sharp-libvips#164 |
see lovell/sharp#3438 for more info, according to rolf it isn't currently being used anywhere
is there a temporary fix this? |
I'm having the similar issue, wondering on ways to solve the situation. |
For macOS 10 support you'll currently need to temporarily pin sharp to v0.31.1 or earlier. macOS 10 reached end-of-life in September this year, hence CI providers removing support for it, hence the unfortunate situation where we weren't able to test using it. Hopefully the fixes and checks now put in place will allow sharp to re-introduce support for the documented macOS 10.13+ from the next release onwards, which is well beyond Apple's official support, and should allow those using e.g. older hardware to continue to benefit from it. |
Hi @lovell, thanks for the advise, will try to give it a go by tonight. |
Well, as it turned out I don't have to wait till tonight, I have access to my local machine again. Here are the steps for everyone else that came here from a Google Search, and I noticed that it's a MacOSX specific issue. I'm on node
And, they're back again working as intended. Thanks, |
@lovell Sorry to bother you, but I didn't find any information about this issue in the changelog for v0.31.3. Will the new version work on MacOS 10.13-10.15 or should we wait for another release? |
@nosferatu500 Please subscribe to this issue for updates specific to it. There will be a future release that re-introduces support for macOS >= 10.13 on a best-effort basis, but please remember there are no longer suitable CI environments available to guarantee this. If you are able to upgrade to macOS 11 then I highly recommend doing so as macOS 10 reached end-of-life in September and is now unsupported by Apple. |
Got it, thank you! PS: I personally use macOS 13, but about 20 people using my app are still using macOS 10.14. So I wanted to know how things are going with support older versions of MacOS. Thank you again. |
Upstream issue: https://gitlab.freedesktop.org/gstreamer/orc/-/issues/44 (I deliberately didn't open a PR there because I don't have access to iOS devices). |
I am on macOS Also it seems like gitlab.freedesktop.org/gstreamer/orc/-/issues/44 has been merged, so maybe that will fix some things? |
can you clarify what fixes you mean and if there is a timeline for a release with them? understood it's impossible to officially support, but unfortunately macOS 10.x still has as much market share as 11/12/13 combined (at least in my userbase). it might help those of us trying to figure out how best to support them. thanks! |
I've been having issues myself with some dependencies of dependencies. So far, what I've found that has fixed the issue, without causing any problems, is downgrading to Here is the full entry in {
"node_modules/sharp": {
"version": "0.31.1",
"resolved": "https://registry.npmjs.org/sharp/-/sharp-0.31.1.tgz",
"integrity": "sha512-GR8M1wBwOiFKLkm9JPun27OQnNRZdHfSf9VwcdZX6UrRmM1/XnOrLFTF0GAil+y/YK4E6qcM/ugxs80QirsHxg==",
"dev": true,
"hasInstallScript": true,
"dependencies": {
"color": "^4.2.3",
"detect-libc": "^2.0.1",
"node-addon-api": "^5.0.0",
"prebuild-install": "^7.1.1",
"semver": "^7.3.8",
"simple-get": "^4.0.1",
"tar-fs": "^2.1.1",
"tunnel-agent": "^0.6.0"
},
"engines": {
"node": ">=14.15.0"
},
"funding": {
"url": "https://opencollective.com/libvips"
}
}
} |
The next release of the prebuilt binaries will include the upstream patch added to orc a couple of weeks ago (via commit lovell/sharp-libvips@d3adcca ) that provides both compile and runtime checks, which is much more comprehensive than our original quick fix. These will be made available as part of sharp v0.32.0. |
FYI: "resolutions": {
"sharp": "0.31.1"
} when needed. |
v0.32.0 now available with prebuilt binaries that contains a patched orc for macOS 10.13+ support. |
l literally just scrapped my whole computer HD and started with a fresh install of Ventura from mojave... took me a solid 2 days to get everything in order. Now sharp supports... LOL. Anyways I guess it was for the best |
Possible install-time or require-time problem
npm install
is the same as the architecture and platform of Node.js used at runtime.Are you using the latest version of sharp?
sharp
as reported bynpm view sharp dist-tags.latest
.If you cannot confirm this, please upgrade to the latest version and try again before opening an issue.
If you are using another package which depends on a version of
sharp
that is not the latest, please open an issue against that package instead.Hello! After updating Sharp from version 0.31.1 to version 0.31.2, some of my users can no longer run my application.
I can guess that this problem is probably inside
libvips
(as shown in the error message), but in the installation guide you state:So I'm just wondering if this bug should be expected to be fixed or should the supported macOS version be higher?
The text was updated successfully, but these errors were encountered: