Add support for stand-alone, pre-resize, and post-resize extraction #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith a topOffset, leftOffset, width, and height.
|
Fantastic work, thank you Brandon. You have made new friends amongst the +1ers of #23. |
lovell
added a commit
that referenced
this pull request
Oct 7, 2014
Add support for stand-alone, pre-resize, and post-resize extraction
|
Thank you! I suppose I could have updated the README with usage/api info as well. I might be able to throw another pull request your way for that tomorrow if someone doesn't get to it before me. |
|
I can do that, no worries. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now rebased onto the alpha branch... I implemented the API (with unit tests) as described in #23 (#23 (comment)). The extract method can be called stand alone or it can be called before and after calling resize. I know that issue is tagged as "work-in-progress" but I didn't see a branch for it and I needed it. My C++ is out of practice at best but I tried to just follow the existing patterns. I don't mind making tweaks or changes if I can make it better.