Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Group 4 (CCITTFAX4) compression to TIFF output #1208

Merged
merged 1 commit into from
Apr 26, 2018

Conversation

woolite64
Copy link
Contributor

This PR addresses #1207, with one concern mentioned below. Any insight/feedback is appreciated.

It isn't clear to me why the test case required .toColourspace('b-w') to compress properly. If we check the input document's metadata, the space is already 'b-w'.

Output of fixtures.inputTiff metadata:

{
  format: 'tiff',
  width: 2464,
  height: 3248,
  space: 'b-w',
  channels: 1,
  depth: 'uchar',
  density: 300,
  hasProfile: false,
  hasAlpha: false,
  orientation: 1
}

@coveralls
Copy link

coveralls commented Apr 25, 2018

Coverage Status

Coverage remained the same at 99.007% when pulling b8e2aca on woolite64:master into 6d2da2b on lovell:master.

@lovell
Copy link
Owner

lovell commented Apr 26, 2018

Hello again, thanks for this, looks great. The default colour behaviour is to convert to sRGB, hence the need to use toColourspace('b-w'). Perhaps this could/should be inferred from the TIFF output options?

@lovell lovell merged commit 5d140d9 into lovell:master Apr 26, 2018
@lovell lovell added this to the v0.20.2 milestone Apr 26, 2018
lovell added a commit that referenced this pull request Apr 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants