Ensure tiles have overlap applied #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovell
reviewed
Oct 18, 2019
lovell
reviewed
Oct 29, 2019
|
Marvellous, thank you very much Brendan for both fixing this bug and adding new tests to help prevent it occurring again. |
lovell
added a commit
that referenced
this pull request
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request addresses #1918, a tile overlap regression spotted in
v0.23.0and higher.I've made the change needed to fix the regression, I've also added a test to prevent it from happening again.
Let me know if there are any improvements that I can make, this is my first PR for Sharp!