Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUE 2105: Added the possibility to set the host for downloading the binary #2217

Merged
merged 3 commits into from
May 22, 2020
Merged

ISSUE 2105: Added the possibility to set the host for downloading the binary #2217

merged 3 commits into from
May 22, 2020

Conversation

malice00
Copy link
Contributor

ISSUE 2105: Added the possibility to set the host for downloading the binary in a way similar to 'prebuild' and 'node-pre-gyp'.

Left in the previous additions using 'sharp_dist_base_url' and 'SHARP_DIST_BASE_URL' to not break working installations.

ISSUE 2105: Added the possibility to set the host for downloading the…
67f29e2 
… binary in a way similar to 'prebuild' and 'node-pre-gyp'
lovell
lovell requested changes May 20, 2020
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, I've left a small comment inline that will need addressing.

install/libvips.js Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d46828a on malice00:ISSUE/2105 into 507eef3 on lovell:master.

@malice00 malice00 requested a review from lovell May 22, 2020 09:55
@lovell lovell merged commit d248ead into lovell:master May 22, 2020
@lovell lovell added this to the v0.25.4 milestone May 22, 2020
@lovell
Copy link
Owner

lovell commented May 22, 2020

Thank you!

@malice00 malice00 mentioned this pull request May 22, 2020
Closed
lovell added a commit that referenced this pull request May 22, 2020
@lovell
Changelog and doc update for #2217
b3dd54d
@lovell lovell mentioned this pull request May 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell Awaiting requested review from lovell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.25.4
Development

Successfully merging this pull request may close these issues.
3 participants
@malice00 @coveralls @lovell