Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure armv7 version if using electron #2292

Closed
wants to merge 2 commits into from
Closed

Ensure armv7 version if using electron #2292

wants to merge 2 commits into from

Conversation

diegodev3
Copy link
Contributor

No description provided.

@diegodev3 diegodev3 mentioned this pull request Jul 13, 2020
Closed
@coveralls
Copy link

coveralls commented Jul 13, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4f75960 on diegodev3:electron_supports into 85459e0 on lovell:master.

lovell
lovell requested changes Jul 13, 2020
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Diego, thank you very much for your PR. Please can you add a test case for this to https://github.com/lovell/sharp/blob/master/test/unit/platform.js

lovell
lovell requested changes Jul 14, 2020
View reviewed changes
test/unit/platform.js Show resolved Hide resolved
@lovell
Copy link
Owner

lovell commented Aug 14, 2020

Landed via commit 45653ca, thanks for the PR.

@lovell lovell closed this Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell lovell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@diegodev3 @coveralls @lovell