Update pipeline.cc #263
Merged
Update pipeline.cc #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the upgrade to nan v2 that was part of v0.11.2 the baton values for blurSigma, sharpenFlat, and sharpenJagged were being cast to int32_t causing blur(sigma) and sharpen(radius, flat, jagged) to fail with "parameters out of range". This patch casts these baton values to doubles.
|
Thank you for finding and fixing this Chris! It looks like I broke this in b7e0a6f. The functional tests failed to detect it as the sharpen tests have yet to take advantage of the fingerprint-based assertions used in most other tests - I'll fix this. |
lovell
added a commit
that referenced
this pull request
Sep 6, 2015
Convert blur and sharpen parameters to double instead of int. This was broken during the nan v2 upgrade by commit b7e0a6f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the upgrade to nan v2 the baton values for blurSigma, sharpenFlat, and sharpenJagged are being cast to int32_t causing blur(sigma) and sharpen(radius, flat, jagged) to fail with "parameters out of range" (at least with nodejs 0.12.7). This patch fixes the issue by casting these baton values to doubles.