Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: limitInputPixels for resolutions higher than uint32 limit #3349

Merged
merged 1 commit into from
Sep 6, 2022
Merged

fix: limitInputPixels for resolutions higher than uint32 limit #3349

merged 1 commit into from
Sep 6, 2022

Conversation

marcosc90
Copy link
Contributor

@marcosc90 marcosc90 commented Sep 5, 2022 •
edited
Loading

This PR fixes an issue with limitInputPixels not working for images with resolutions exceeding the uint32 limit.

The added test fails on main branch.

@coveralls
Copy link

coveralls commented Sep 5, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 5a97e9d on marcosc90:fix-uint32-limit into f7b29d7 on lovell:main.

kleisauke
kleisauke reviewed Sep 5, 2022
View reviewed changes
src/common.cc Outdated Show resolved Hide resolved
@lovell lovell merged commit eee0dd3 into lovell:main Sep 6, 2022
@lovell
Copy link
Owner

lovell commented Sep 6, 2022

Thank you!

@lovell lovell added this to the v0.31.1 milestone Sep 6, 2022
@marcosc90 marcosc90 deleted the fix-uint32-limit branch September 6, 2022 08:06
lovell added a commit that referenced this pull request Sep 7, 2022
@lovell
Docs: changelog and credit for #3349
f5da147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kleisauke kleisauke kleisauke left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.31.1
Development

Successfully merging this pull request may close these issues.
4 participants
@marcosc90 @coveralls @lovell @kleisauke