Added .linear(a, b) operation for levels adjustment #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovell
requested changes
Mar 25, 2017
| * @throws {Error} Invalid parameters | ||
| */ | ||
| const linear = function linear (a, b) { | ||
| if (!is.defined(linear)) { |
There was a problem hiding this comment.
Did you mean to check a and/or b here?
| this.options.linearA = a; | ||
| this.options.linearB = b; | ||
| } else { | ||
| throw new Error('Invalid linear arguments ' + a + ',' + b); |
There was a problem hiding this comment.
ES6 template literals are "allowed" if you'd like to use them here :)
| const fixtures = require('../fixtures'); | ||
|
|
||
| describe('Linear adjustment', function () { | ||
| it('applies levels adjustment', function (done) { |
There was a problem hiding this comment.
Are you able to add a test for the code path that removes/rejoins the alpha channel?
There was a problem hiding this comment.
Oh, and a test for the throwing of "Invalid linear arguments" please.
|
Feel free to add yourself to the contributors list also! |
This was referenced Nov 14, 2017
Merged
|
This PR has formed the basis of another PR - see #1024 |
|
Superseded by #1024 - thank you for taking the time to submit this PR - I expect this feature to ship in v0.19.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just exposes the libvips'
linearmethod which is useful when you need to do a manual levels adjustment and not use the more automaticnormalizemethod.