Delay visibility propagation until deps are known (#1739)

Fixes yarnpkg/yarn#761
lovelypuppy0607 · Nov 11, 2016 · 6174a6a · 6174a6a
1 parent baa6b32
commit 6174a6a
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/src/package-request.js b/src/package-request.js
@@ -224,8 +224,6 @@ export default class PackageRequest {
       invariant(ref, 'Resolved package info has no package reference');
       ref.addRequest(this);
       ref.addPattern(this.pattern, resolved);
-      ref.addOptional(this.optional);
-      ref.addVisibility(this.visibility);
       return;
     }
 
@@ -280,6 +278,12 @@ export default class PackageRequest {
 
     await Promise.all(promises);
     ref.addDependencies(deps);
+
+    // Now that we have all dependencies, it's safe to propagate optional & visibility
+    for (const otherRequest of ref.requests.slice(1)) {
+      ref.addOptional(otherRequest.optional);
+      ref.addVisibility(otherRequest.visibility);
+    }
   }
 
   /**